Upgrade to check-spelling v0.0.22 #2316
Conversation
453ac20 to
3375800
Compare
There was a problem hiding this comment.
Hey @jsoref ! Thank you very much for this PR, really appreciate it. This is looking great.
One thing we'd like to change: there are security concerns that make me a little uneasy about allowing the permissions that are required for the new bot interaction feature that is introduced in this new release. I understand that it's only running in external repositories, but still I think we're going to want to disable it.
I have added comments where I think we need to make the changes - let me know if you have any comments/questions/concerns, or see anything else.
Also I'll gladly make those changes myself, I just thought maybe you'd want to author that yourself.
Thank you very much again!
3375800 to
f0d6f4c
Compare
|
Oh, lemme rebase... |
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
- enables sarif reporting
- enables checking dependabot PRs to validate extra_dictionaries in the
future
- refreshes dictionaries
- refreshes metadata
f0d6f4c to
8795470
Compare
| @@ -547,7 +547,8 @@ customObjectInstantitationMethod | |||
| # base64 encoded content | |||
| ([`'"])[-a-zA-Z=;:/0-9+]+=\g{-1} | |||
| # base64 encoded content in xml/sgml | |||
| >[-a-zA-Z=;:/0-9+]+=</ | |||
| # Commented out because of false positives | |||
There was a problem hiding this comment.
I think this false positive is only present in v0.0.21 and will go away in v0.0.22 (one of the many bugs that are fixed). But it doesn't matter.
There was a problem hiding this comment.
I should have called it out in the PR description.
In the release notes, it's listed as:
🐜 Bug fixes
🩹 Pattern suggestions shouldn't trip over active patterns
Change Description
Upgrades check-spelling to v0.0.22
Rationale
\n/\r/\tare no longer special cased=won't trip on current patternshttps://github.com/check-spelling/check-spelling/releases/tag/v0.0.22
Testing/Review Recommendations
PRs can be made into https://github.com/check-spelling-sandbox/fprime/tree/check-spelling-0.0.22 to see how it behaves.
Future Work