Update STest #2137
Merged
Update STest #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't we just update to using the STest package as opposed to copying in updated files? |
|
Yes, that would be an improvement. |
|
But it requires changes to the F Prime build infrastructure. This PR is a minimal change to get the latest version. |
|
Agreed. However, we make exactly the same argument each time we update files in this area. |
LeStarch
approved these changes
Jul 18, 2023
|
Is there an issue open to make STest a subrepo? If not, let's open an issue and get it in the priority queue. |
thomas-bc
pushed a commit
that referenced
this pull request
Aug 4, 2023
* Update STest * Code cleanup * Revise Pick.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update STest to the latest.
Pick::lowerUpper(lower, upper)could returnupper+1in rare cases.