Fix bug in Fw::Buffer #2136
Merged
Fix bug in Fw::Buffer #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this means that the new buffer is now invalid? |
|
I think so. I think a buffer should be considered invalid if the pointer is Note the SDD implies that if |
|
But then it should be an invariant of |
|
For this PR I made the minimal change to avoid an assertion failure that I thought shouldn't be happening. |
|
This change seems correct to me. |
LeStarch
approved these changes
Jul 18, 2023
thomas-bc
pushed a commit
that referenced
this pull request
Aug 4, 2023
* Fix bug in Fw::Buffer * Revise null pointer check in Serializable.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The copy constructor for
Fw::Bufferwas causing an assertion failure when copying an invalid buffer. I noticed this because I was writing unit tests that passed invalid buffers around, and I saw the assertion failure.This patch fixes the issue.
Note: For correctness, I had to replace
FW_ASSERT(p)withFW_ASSERT(p != nullptr)in one place. Otherwise we are assuming thatnullptr == 0which is not guaranteed to be true. We should make this change consistently throughout the framework, but I made the minimal change for now.