Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency for XML generation #2044

Merged
merged 2 commits into from
May 24, 2023

Conversation

sobkulir
Copy link
Contributor

@sobkulir sobkulir commented May 23, 2023

Originating Project/Creator F'
Affected Component Autocoders/codegen
Related Issue(s) #2043

Change Description

The codegen.py utility depends on in-source generated files Autocoders/Python/src/fprime_ac/generators/templates/**/**.py. However, when generating topology XML files like TopologyAppDictionary, this dependency is not present. This PR adds the dependency.

There's also a duplicate dependency on ${AC_INPUT_FILE} so I removed one occurrence.

Rationale

I was not able to build the Ref app of devel branch with fpp devel branch with error:

Traceback (most recent call last):
  File "/zephyr-workspace/fprime-zephyr-app/fprime/fprime/Autocoders/Python/bin/codegen.py", line 28, in <module>
    from fprime_ac.utils import (
  File "/zephyr-workspace/fprime-zephyr-app/fprime/fprime/Autocoders/Python/src/fprime_ac/utils/ArrayGenerator.py", line 18, in <module>
    from fprime_ac.generators.templates.arrays import array_cpp, array_hpp
ImportError: cannot import name 'array_cpp' from 'fprime_ac.generators.templates.arrays' (/zephyr-workspace/fprime-zephyr-app/fprime/fprime/Autocoders/Python/src/fprime_ac/generators/templates/arrays/__init__.py)
gmake[3]: *** [Ref/Top/CMakeFiles/Ref_Top.dir/build.make:203: Ref/Top/RefTopologyAppDictionary.xml] Error 1
gmake[2]: *** [CMakeFiles/Makefile2:8407: Ref/Top/CMakeFiles/Ref_Top.dir/all] Error 2
gmake[1]: *** [CMakeFiles/Makefile2:2045: CMakeFiles/Ref.dir/rule] Error 2
gmake: *** [Makefile:195: Ref] Error 2
[ERROR] CMake erred with return code 2

I bisected the first commit of fpp with which tne build fails, but it doesn't seem fishy: nasa/fpp@d1d14ae

Future Work

@LeStarch
Copy link
Collaborator

Looks right to me. @thomas-bc ?

@LeStarch LeStarch merged commit 7beddcc into nasa:devel May 24, 2023
@sobkulir sobkulir deleted the codegen-dep-fix branch May 25, 2023 08:31
sobkulir added a commit to sobkulir/fprime that referenced this pull request Jun 15, 2023
* Add codegen dependency

* Remove repeated dependency
Boehm-Michael pushed a commit to Boehm-Michael/fprime that referenced this pull request Jun 22, 2023
* Add codegen dependency

* Remove repeated dependency
thomas-bc pushed a commit that referenced this pull request Aug 4, 2023
* Add codegen dependency

* Remove repeated dependency
thomas-bc added a commit that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants