Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made assert clickable (#1847) #2022

Merged
merged 2 commits into from
May 24, 2023
Merged

Made assert clickable (#1847) #2022

merged 2 commits into from
May 24, 2023

Conversation

SMorettini
Copy link
Contributor

Affected Architectures(s) Fw/Assert and Fw/Logger
Related Issue(s) #1847

Change Description

Made assert message clickable

LeStarch
LeStarch reviewed May 13, 2023
View reviewed changes
Fw/Types/Assert.cpp Outdated Show resolved Hide resolved
LeStarch
LeStarch reviewed May 13, 2023
View reviewed changes
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but was wondering your thoughts on the 32bit file ID messages.

@SMorettini
Copy link
Contributor Author

SMorettini commented May 14, 2023 •
edited
Loading

I cannot understand why the CI is failing, in my local branch everything works fine, I cannot reproduce the error in the CI.
UPDATE(17/05): Now it passed without any code change.

@LeStarch
Copy link
Collaborator

@SMorettini our hardware cluster got powered off and thus none-of-the HITL tests worked.

@LeStarch LeStarch merged commit f5b34f2 into nasa:devel May 24, 2023
@SMorettini SMorettini deleted the 1847-Clickable-Assert-Messages branch May 25, 2023 07:01
sobkulir pushed a commit to sobkulir/fprime that referenced this pull request Jun 15, 2023
@SMorettini @sobkulir
Made assert clickable (nasa#1847) (nasa#2022)
71c61f9 
* Made assert clickable (nasa#1847)

* Update asserts with file id

---------

Co-authored-by: Simone Morettini <s.morettini.cs@gmail.com>
Boehm-Michael pushed a commit to Boehm-Michael/fprime that referenced this pull request Jun 22, 2023
@SMorettini @Boehm-Michael
Made assert clickable (nasa#1847) (nasa#2022)
a2ea39e 
* Made assert clickable (nasa#1847)

* Update asserts with file id

---------

Co-authored-by: Simone Morettini <s.morettini.cs@gmail.com>
@SMorettini SMorettini mentioned this pull request Jul 7, 2023
Merged
thomas-bc pushed a commit that referenced this pull request Aug 4, 2023
@SMorettini @thomas-bc
Made assert clickable (#1847) (#2022)
86f7598 
* Made assert clickable (#1847)

* Update asserts with file id

---------

Co-authored-by: Simone Morettini <s.morettini.cs@gmail.com>
thomas-bc added a commit that referenced this pull request Aug 4, 2023
@thomas-bc
Revert "Made assert clickable (#1847) (#2022)"
a60a5c3 
This reverts commit 86f7598.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-bc thomas-bc thomas-bc approved these changes

@LeStarch LeStarch LeStarch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SMorettini @LeStarch @thomas-bc