Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fully qualified namespace in AC component .hpp #1935

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Use fully qualified namespace in AC component .hpp #1935

merged 1 commit into from
Mar 17, 2023

Conversation

pcrosemurgy
Copy link
Contributor

@pcrosemurgy pcrosemurgy commented Mar 16, 2023

Originating Project/Creator @pcrosemurgy
Affected Component Autocoded component .hpp files
Affected Architectures(s) Component autocoding
Related Issue(s) N/A
Has Unit Tests (y/n) n
Builds Without Errors (y/n) y
Unit Tests Pass (y/n) y
Documentation Included (y/n) n

Change Description

This PR fixes the component .hpp autocoder to use the fully qualified namespace.

Rationale

Prior to this PR a name collision would occur if a duplicate component name was found. For example: Svc.Framer and Foo.Framer.

Testing/Review Recommendations

N/A.

Future Work

My understanding is this change will be replaced by FPP autocoding in the near future.

@pcrosemurgy pcrosemurgy marked this pull request as ready for review March 16, 2023 21:21
@pcrosemurgy pcrosemurgy changed the title Use fully qualified namespace and name in AC component .hpp Use fully qualified namespace in AC component .hpp Mar 16, 2023
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like what I'd expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants