Remove references to install command from the tutorial. Fixes #1877 #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tutorial refers to the "install" command in the 'Build Ref Deployment' section. However, that command was removed in 20b5f29, a commit released as early as v2.0.0~193^2. This commit removes references to the install command from the tutorial. The mention that the build command also copies the binaries to the bin dir is moved earlier in the text, simply because it flows better when the rest of the note about the install command is removed.
LeStarch
approved these changes
Mar 11, 2023
|
@LeStarch This was reopened. Is everything ok, and should I be filing PRs against |
|
@ivanperez-keera thank you for making this PR! PRs should be opened against |
|
@thomas-bc Thanks! I'll do that in the future. As I understand it, I don't need to change anything (e.g., rebase the commits in my fork and force-push) but, if I do, please let me know. |
|
@thomas-bc I think you fixed these CI issues. How should we handle PRs like this that failed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Remove references to the install command from the tutorial.
Rationale
The tutorial refers to the
installcommand in the 'Build Ref Deployment' section. However, that command was removed in 20b5f29, a commit released as early as v2.0.0~193^2.Testing/Review Recommendations
Ensure that, as written now, claims about the
buildcommand are accurate.Future Work
None.