Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/fix cmake fail with no error #1854

Merged

Conversation

dmitri-mcguckin
Copy link
Contributor

@dmitri-mcguckin dmitri-mcguckin commented Jan 18, 2023

Originating Project/Creator JPL
Affected Component n/a
Affected Architectures(s) CMake
Related Issue(s) #1850
Has Unit Tests (y/n) n/a
Builds Without Errors (y/n) yes
Unit Tests Pass (y/n)
Documentation Included (y/n) yes

Change Description

This is the proposed fix to some of the logging problems discussed in Issue #1850. It adds documentation to docs/INSTALL.md for a situation in which CMake fails due to permission issues but does not relay the reason for this failure.

Rationale

The goal of this is to improve logging while troubleshooting situations where F' does not build.

Testing/Review Recommendations

n/a

Future Work

It may be possible to ad-hoc modify permissions of the helper script at build-time.

Something as simple as this could achieve this behavior

execute_process(COMMAND "chmod 700 ${FPP_LOCATE_DEFS_HELPER}")

Although there's already plenty of discussion regarding if CMake should even be allowed to do this if it's not part of a system install.

I'm open to suggestions/comments.

Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing down error messages is always a good idea in my opinion!
Adding a few comments, but this looks good to me.

docs/INSTALL.md Outdated Show resolved Hide resolved
docs/INSTALL.md Outdated Show resolved Hide resolved
@LeStarch
Copy link
Collaborator

This PR is against the master branch. We should switch it to devel.

@LeStarch LeStarch changed the base branch from master to devel January 18, 2023 17:29
@dmitri-mcguckin
Copy link
Contributor Author

Hmn, looks like the CI keeps failing because there are no Raspberry Pi runners available.

Since this change is mostly logging related anyhow, do we want to forego that step of the CI?

Please advise.

@LeStarch
Copy link
Collaborator

This change does not require RPI to pass the build. @thomas-bc are you ready to merge this?

Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LeStarch ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants