Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize Array before used #1668

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Conversation

howjmay
Copy link
Contributor

@howjmay howjmay commented Sep 24, 2022

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Initialize array before using it.

Rationale

For some compiler, a declared array may not be initialized or initialized to zero. Therefore, using array directly before initializing it is dangerous.

Testing/Review Recommendations

Fill in testing procedures, specific items to focus on for review, or other info to help the team verify these changes are flight-quality.

Future Work

Note any additional work that will be done relating to this issue.

@LeStarch LeStarch changed the base branch from master to devel September 26, 2022 17:00
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is an improvement!

@LeStarch
Copy link
Collaborator

C++ check is a known issue. Bypassing. All other checks pass.

@LeStarch LeStarch merged commit 378e546 into nasa:devel Sep 26, 2022
@howjmay howjmay deleted the fix-uninitialized-array branch September 27, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants