Adding modular dependencies to enable compiling with shared libraries #1653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Added modular dependencies to CmakeLists.txt for port type folders in
Drv/
andSvc/
to enable compilation with the cmake flagBUILD_SHARED_LIBS
set to ON.Rationale
These additions are necessary for users who need to build with shared libs.
Testing/Review Recommendations
Built the Ref deployment with and without the
BUILD_SHARED_LIBS
flag, and the deployment builds successfully. I also tested this with an external deployment and it built successfully. However, it is possible that there are additional changes required for other components/ports that were not included in the Ref or my external deployments.Future Work
It would be a good idea to include this in the CI workflow so that this functionality is continually supported!