Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 #1644

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Patch 1 #1644

merged 2 commits into from
Sep 26, 2022

Conversation

fchapoton
Copy link
Contributor

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

instead of os.path.join, use pathlib.Path objects (here just in one file)

Rationale

using pathlib is very convenient and more compact code to handle paths

Testing/Review Recommendations

Fill in testing procedures, specific items to focus on for review, or other info to help the team verify these changes are flight-quality.

Future Work

Note any additional work that will be done relating to this issue.

trying to use Path from pathlib
@LeStarch
Copy link
Collaborator

This looks good. Thanks!

Note: We are trying to minimize changes to Autocoders, so unless there are security or critical bug fixes, we may close future changes to this package. https://github.com/nasa/fprime/blob/master/CONTRIBUTING.md#ways-of-contributing

@LeStarch LeStarch merged commit d76db53 into nasa:devel Sep 26, 2022
@fchapoton fchapoton deleted the patch-1 branch September 27, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants