Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
GENERATED_SOURCES
, a list of sources generated by previous autocoders, to the_filter_sources
function incmake/autocoder/autocoder.cmake
ai_xml_is_supported
function incmake/autocoder/ai_xml.cmake
to also filter sources against previously generated sources. This means that XML autocoder will only receive Ai.xml files whose corresponding Ac.cpp and Ac.hpp files have not already been generated by the FPP autocoder, preventing it from overwriting those files.Rationale
This change is necessary to support FPP v1.1.0, which will include C++ code generation for FPP enums, arrays, and structs, intended to replace the XML autocoder's C++ code generation for enums, arrays, and structs.