Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Added
unlock
alias forOs::Mutex
type.Rationale
Os::Mutex
is now BasicLoackable.Testing/Review Recommendations
Added test in Os folder but is really only a compile-time check. Perhaps there is a better way to assert at compile-time that the BaiscLockable requirements are satisfied. For now a
std::lock_guard
is instantiated with anOs::Mutex
parameter to show correctness.Future Work
When/if F' C++ standard bumps to C++17 or above Mutex could be upgraded to satisfy the Lockable requirement.