Avoid assert on BufferManager destruction #1383
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Avoid calling
BufferManager::cleanup()
ifBufferManager::setup()
was never called.Rationale
Relevant when FSW exits early (before initialization). The BufferManager destructor will be called and either an assertion will trip saying
m_allocator
is NULL or segfault if there is no assertion hook set up.fprime/Svc/BufferManager/BufferManagerComponentImpl.cpp
Lines 65 to 74 in 582f180