Handle 0 and negative numbers on string_copy

[Drosaca]

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

---

Change Description

Avoids to write '\0' before the destination pointer if num is 0
which is set by the following line:

destination[ num - 1] = '\0'

[ThibFrgsGmz]

The verification of the negative number seems useless because the number passed in parameter is not signed. Right ?

[Drosaca]

@ThibFrgsGmz Indeed the check of negative values has been removed, nevertheless when num equals zero '\0' will still be written at destination[-1]

[LeStarch]

I agree with this improvement. In the case where 0 is supplied as a limiting length, then the destination should return unchanged as the limit does not even account for a terminating \0. This will will remove the error.

[LeStarch]

Closed and reopened as I needed to try and re-trigger a complete rerun of CI to fix the python formatting bug. If it doesn't work, we'll ignore that check as the python was not touched.