-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submission of UartFramer component #1261
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix BufferManager bounds checking logic
fix: change U64 to POINTER_CAST
Import/tlm packetizer
Update/prm buffer
LeStarch
approved these changes
Feb 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what I'd expect for this component.
LeStarch
pushed a commit
that referenced
this pull request
Jun 29, 2022
* Changed PrmBuffer m_data to m_bufferData for VxWorks * More m_data instances * VxWorks and virtual destructors * Added Vxworks fatal handler compile * Fixed active component schematron * Changed ActiveTextLogger to use Fw::Logger to avoid VxWorks mushing of output * Importing TlmPacketizer * fix(BufferManager): size checking logic and assert cleanup * fix: change U64 to POINTER_CAST * TlmPacketizer unit tests pass * Adding codegen for packets * More work on packet generator * Fixing generated pathnames * Fixes to topology for TlmPacketizer and TlmPacketizer name updates * Typo * Fix TlmPacketizer unit tests after name change * Additional fixes to packet telemetry script and packet contents * ran tlm_packet_gen.py through black formatter * Added spellcheck words * Added join() for pktTlm * Fix to ai_parser.py formatting * More spell check exclusions * Updated headers and const * Code copied in * Starting on SDD * new image path * More SDD * SDD done * Unit tests complete * sdd typo Co-authored-by: Kyle Botteon <botteon@jpl.nasa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drv/UartFramer
Drv/UartFramer/docs/sdd.md
Change Description
This adds a new component
Drv/UartFramer
. It acts as an adapter component betweenFramer
/Deframer
andDrv/LinuxSerialDriver
so that a UART can be used as a connection to the ground system.Also adds a spelling check exclusion for Visio
.vsdx
files.Rationale
If an embedded process does not have access to a network connection or a radio for a ground interface, this allows a simple UART to act as aconnection.
Testing/Review Recommendations
Have a developer review it for coverage or coding errors. It has been tested successfully on a JPL internal project.
Future Work
None at this time.