Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission of UartFramer component #1261

Merged
merged 47 commits into from
Feb 8, 2022
Merged

Conversation

timcanham
Copy link
Collaborator

@timcanham timcanham commented Feb 5, 2022

Originating Project/Creator JPL internal
Affected Component Drv/UartFramer
Affected Architectures(s) all
Related Issue(s) None
Has Unit Tests (y/n) y
Builds Without Errors (y/n) y
Unit Tests Pass (y/n) y
Documentation Included (y/n) Drv/UartFramer/docs/sdd.md

Change Description

This adds a new component Drv/UartFramer. It acts as an adapter component between Framer/Deframer and Drv/LinuxSerialDriver so that a UART can be used as a connection to the ground system.

Also adds a spelling check exclusion for Visio .vsdx files.

Rationale

If an embedded process does not have access to a network connection or a radio for a ground interface, this allows a simple UART to act as aconnection.

Testing/Review Recommendations

Have a developer review it for coverage or coding errors. It has been tested successfully on a JPL internal project.

Future Work

None at this time.

timcanham and others added 30 commits June 17, 2021 13:29
Fix BufferManager bounds checking logic
@timcanham timcanham requested a review from LeStarch February 5, 2022 02:38
@timcanham timcanham self-assigned this Feb 5, 2022
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I'd expect for this component.

@LeStarch LeStarch merged commit 72bc851 into nasa:devel Feb 8, 2022
LeStarch pushed a commit that referenced this pull request Jun 29, 2022
* Changed PrmBuffer m_data to m_bufferData for VxWorks

* More m_data instances

* VxWorks and virtual destructors

* Added Vxworks fatal handler compile

* Fixed active component schematron

* Changed ActiveTextLogger to use Fw::Logger to avoid VxWorks mushing of output

* Importing TlmPacketizer

* fix(BufferManager): size checking logic and assert cleanup

* fix: change U64 to POINTER_CAST

* TlmPacketizer unit tests pass

* Adding codegen for packets

* More work on packet generator

* Fixing generated pathnames

* Fixes to topology for TlmPacketizer and TlmPacketizer name updates

* Typo

* Fix TlmPacketizer unit tests after name change

* Additional fixes to packet telemetry script and packet contents

* ran tlm_packet_gen.py through black formatter

* Added spellcheck words

* Added join() for pktTlm

* Fix to ai_parser.py formatting

* More spell check exclusions

* Updated headers and const

* Code copied in

* Starting on SDD

* new image path

* More SDD

* SDD done

* Unit tests complete

* sdd typo

Co-authored-by: Kyle Botteon <botteon@jpl.nasa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants