Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing GenericHub.hpp file #1192

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Added missing GenericHub.hpp file #1192

merged 1 commit into from
Jan 3, 2022

Conversation

saba-ja
Copy link
Contributor

@saba-ja saba-ja commented Jan 2, 2022

Originating Project/Creator F Prime
Affected Component GenericHub
Affected Architectures(s) NA
Related Issue(s) NA
Has Unit Tests (y/n) No
Builds Without Errors (y/n) Yes
Unit Tests Pass (y/n) Yes
Documentation Included (y/n) No

Change Description

Generalized GenericHub.hpp was missing in the Svc/GenericHub. This was causing the following error:

In file included from /home/work/Swift/build-fprime-automatic-microblaze-qcp/Swift/Top/SwiftTopologyAc.cpp:12:
Swift/Top/CMakeFiles/Swift_Top.dir/build.make:245: recipe for target 'Swift/Top/CMakeFiles/Swift_Top.dir/SwiftTopologyAc.cpp.o' failed
/home/work/Swift/build-fprime-automatic-microblaze-qcp/Swift/Top/SwiftTopologyAc.hpp:29:10: fatal error: Svc/GenericHub/GenericHub.hpp: No such file or directory
   29 | #include "Svc/GenericHub/GenericHub.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[3]: *** [Swift/Top/CMakeFiles/Swift_Top.dir/SwiftTopologyAc.cpp.o] Error 1
CMakeFiles/Makefile2:7945: recipe for target 'Swift/Top/CMakeFiles/Swift_Top.dir/all' failed
[ERROR] CMake erred with return code 2

Rationale

Generalized header has been added.

Testing/Review Recommendations

Ran GenericHub UT test after adding the generalized header with no test failure.

Future Work

Need to check all components to make sure they are not missing any files after the upgrade to the F Prime 3.0

@LeStarch
Copy link
Collaborator

LeStarch commented Jan 3, 2022

Good catch!

@LeStarch LeStarch merged commit 90b05b6 into nasa:devel Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants