Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snprintf #1156

Merged
merged 6 commits into from
Dec 13, 2021
Merged

Fix snprintf #1156

merged 6 commits into from
Dec 13, 2021

Conversation

FabrizioSandri
Copy link
Contributor

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

snprintf changes in some Fw classes as already discussed in pull request #1151 .

Rationale

To avoid redundancy and improve overall readability of the code.

Testing/Review Recommendations

I made some changes in some Fw classes. Specifically, I removed some redundant code that is already implemented in the snprintf function as already discussed with @LeStarch in pull request #1151 .

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@LeStarch LeStarch merged commit 1411b40 into nasa:devel Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants