Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed BasicTypes preproc checks for pointer type #1150

Merged

Conversation

vietjtnguyen
Copy link

Originating Project/Creator CADRE
Affected Component n/a
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n) n/a
Builds Without Errors (y/n) y
Unit Tests Pass (y/n) n/a
Documentation Included (y/n) n/a

Change Description

Changes the preprocessor checks for defining the POINTER_CAST type so that they're acceptable by the compiler even if the expected architecture-dependent definitions are not present.

Rationale

When built in the CADRE cross compilation environment with -Werror enabled this produces compilation errors pertaining to checking against undefined preprocessor variables (the originating warning was -Wundef if I remember correctly).

Testing/Review Recommendations

Test against software built against architectures covered by these different preprocessor definitions that are checked.

Future Work

n/a

@LeStarch LeStarch self-requested a review December 13, 2021 17:14
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes do is to add a "is defined" check before checking values. I am ok with this change.

@LeStarch LeStarch merged commit f5f4a33 into nasa:devel Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants