Allow removal of text loggers from build with CMake variable. #1071
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow removal of text loggers from build with CMake variable. Otherwise build fails if FW_ENABLE_TEXT_LOGGING == 0.
Change Description
In https://github.com/nasa/fprime/blob/devel/Svc/CMakeLists.txt , move adding of Text Logger components into a
if (NOT FPRIME_DISABLE_TEXT_LOGGERS)
conditional.Rationale
If FW_ENABLE_TEXT_LOGGING is set to 0 (
fprime/config/FpConfig.hpp
Line 290 in 401c142
Now, deployments that wish to set FW_ENABLE_TEXT_LOGGING to 0 can add
FPRIME_DISABLE_TEXT_LOGGERS = 1
to their CMakeLists to prevent the adding of these components.Testing/Review Recommendations
None
Future Work
There may be a more desirable way to do this.