Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run CMake UT CI On Minimum Required CMake Version #2618

Closed
LeStarch opened this issue Mar 26, 2024 · 2 comments · Fixed by #2619
Closed

Run CMake UT CI On Minimum Required CMake Version #2618

LeStarch opened this issue Mar 26, 2024 · 2 comments · Fixed by #2619
Assignees
@LeStarch
Labels
CI Issues pertaining to Continuous Integration cmake Issues pertaining to the CMake build system. enhancement

Comments

@LeStarch
Copy link
Collaborator

F´ Version
Affected Component

Feature Description

When running. the CMake UTs, we should run them on the minimum CMake version to ensure that version isn't inadvertently broken.
@LeStarch LeStarch added enhancement cmake Issues pertaining to the CMake build system. CI Issues pertaining to Continuous Integration labels Mar 26, 2024
@LeStarch LeStarch linked a pull request Mar 26, 2024 that will close this issue
Split CMake tests and run with minimum cmake #2619
Merged
@LeStarch LeStarch self-assigned this Mar 26, 2024
LeStarch added a commit to LeStarch/fprime that referenced this issue Mar 26, 2024
@LeStarch
Disambiguate fpp error messages. Fixes: nasa#2618
e9208e7
LeStarch added a commit to LeStarch/fprime that referenced this issue Mar 26, 2024
@LeStarch
Disambiguate fpp error messages. Fixes: nasa#2618
0e7cd70
@thomas-bc
Copy link
Collaborator

I believe we meant to close #2615 instead. Reopening this one.

@thomas-bc thomas-bc reopened this Mar 26, 2024
@LeStarch
Copy link
Collaborator Author

@thomas-bc this is fixed by #2619. I must have gotten my annotations wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeStarch LeStarch

Labels
CI Issues pertaining to Continuous Integration cmake Issues pertaining to the CMake build system. enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split CMake tests and run with minimum cmake LeStarch/fprime
2 participants
@LeStarch @thomas-bc