Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActiveRateGroupImpl left in Fprime from previous versions #1920

Closed
SMorettini opened this issue Mar 2, 2023 · 0 comments
Closed

ActiveRateGroupImpl left in Fprime from previous versions #1920

SMorettini opened this issue Mar 2, 2023 · 0 comments
Labels
enhancement

Comments

@SMorettini
Copy link
Contributor

F´ Version
Affected Component

Feature Description

In Svc/ActiveRateGroup there is the file ActiveRateGroupImpl.cpp that is not used anywhere. It seems that it's left from previous Fprime version and now it's substituted by ActiveRateGroup.cpp.

Rationale

If you agree with my analysis I'll proceed to remove it from the source.
@SMorettini SMorettini changed the title ActiveRateGroupImpl left in Fprime from previous vesions ActiveRateGroupImpl left in Fprime from previous versions Apr 17, 2023
SMorettini pushed a commit to SMorettini/fprime that referenced this issue May 13, 2023
Removed ActiveRateGroupImpl (nasa#1920)
7903d81
SMorettini pushed a commit to SMorettini/fprime that referenced this issue May 13, 2023
Removed ActiveRateGroupImpl (nasa#1920)
22d7261
@SMorettini SMorettini mentioned this issue May 13, 2023
Merged
LeStarch pushed a commit that referenced this issue May 17, 2023
@SMorettini
Removed ActiveRateGroupImpl (#1920) (#2023)
13393f9 
Co-authored-by: Simone Morettini <s.morettini.cs@gmail.com>
Boehm-Michael pushed a commit to Boehm-Michael/fprime that referenced this issue Jun 22, 2023
@SMorettini @Boehm-Michael
Removed ActiveRateGroupImpl (nasa#1920) (nasa#2023)
caa2d10 
Co-authored-by: Simone Morettini <s.morettini.cs@gmail.com>
thomas-bc pushed a commit that referenced this issue Aug 4, 2023
@SMorettini @thomas-bc
Removed ActiveRateGroupImpl (#1920) (#2023)
c3750d6 
Co-authored-by: Simone Morettini <s.morettini.cs@gmail.com>
thomas-bc added a commit that referenced this issue Aug 4, 2023
@thomas-bc
Revert "Removed ActiveRateGroupImpl (#1920) (#2023)"
7782e37 
This reverts commit c3750d6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SMorettini