Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FW_NO_ASSERT does not work #1706

Closed
timcanham opened this issue Oct 4, 2022 · 2 comments
Closed

FW_NO_ASSERT does not work #1706

timcanham opened this issue Oct 4, 2022 · 2 comments
Assignees
Labels

Comments

@timcanham
Copy link
Collaborator

timcanham commented Oct 4, 2022

F´ Version
Affected Component

Problem Description

Turning off asserts by setting assert level to FW_NO_ASSERT causes compilation issues with all the classes subclassing AssertHook.

We have 2 options:

  1. Conditionally compile all classes subclassing AssertHook
  2. Always define AssertHook class, and disable asserts at the macro level
@timcanham timcanham added the bug label Oct 4, 2022
@LeStarch
Copy link
Collaborator

@timcanham I think option 2 is best. It does leave extra code around when not using asserts, but it limits a very suspect use of conditional compilation. If you agree, please let me know.

@LeStarch LeStarch self-assigned this Dec 20, 2023
@timcanham
Copy link
Collaborator Author

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants