Always print output when refreshing cache #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeStarch
approved these changes
Nov 8, 2023
|
We could rename the target to "refresh". |
LeStarch
requested changes
Nov 9, 2023
LeStarch
reviewed
Nov 15, 2023
| print_output=self.verbose, | ||
| ) | ||
| # Backwards compatibility: refresh_cache was named noop until v3.3.x | ||
| if self.is_target_supported(build_dir, "noop"): |
There was a problem hiding this comment.
Given the slowness of printing targets, perhaps it is faster to run "refresh_cache" and trap "No rule to make target `llkjldksjlksdj'. Stop." and then run "noop"?
There was a problem hiding this comment.
Will revisit with the ninja support work.
LeStarch
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Fix nasa/fprime#1992
When
cmake_refresh_cache()is triggered, always print the cmake regeneration output.Rationale
fprime-util buildet al. have when target exists but requires a refresh (e.g..fppfile was modified). Output of regeneration is printed out.fprime-util generate), and the familiar-looking output confirms that.Comment
This has the side effect of also printing the
Built target noopto the screen... which I don't really like.I've been looking in other ways to do this, but was unsuccessful. A fix could be to go in the CMakeHandler._communicate and explicitly skip lines that equal
Built target noop\n, but that sounds rather ugly...Do you have any suggestion?