-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDSC-3560: Adding collection sort key parameter into URL #1868
Open
william-valencia
wants to merge
16
commits into
nasa:main
Choose a base branch
from
william-valencia:EDSC-3560
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+362
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1868 +/- ##
=======================================
Coverage 93.41% 93.42%
=======================================
Files 781 781
Lines 19239 19256 +17
Branches 5004 4997 -7
=======================================
+ Hits 17973 17990 +17
Misses 1181 1181
Partials 85 85 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eudoroolivares2016
requested changes
Feb 25, 2025
static/src/js/components/SearchPanels/__tests__/SearchPanels.test.jsx
Outdated
Show resolved
Hide resolved
9781bd5
to
68d5117
Compare
eudoroolivares2016
approved these changes
Mar 4, 2025
Tested feature locally including with a test with an empty user preferences |
e963b6d
to
612f780
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
When the user clicks on a non default collection sort key (or if preferences are set, not preferred sort key) , they key shows up as a parameter in the URL
What is the Solution?
Updated code to add collection sort key parameter to the URL and have EDSC use collection sort key parameter in the URL if present
What areas of the application does this impact?
Collection Sorting on EDSC and the URL's shown on the browser. Also the user preferred sort key will be used if set.
Testing
Reproduction steps
Open a browser and navigate to EDSC. While logged out, select a different Collection Sort Key ie Relevance, Start Date, or End Date. Ensure that a corresponding query parameter gets added to the URL:
ie:
csk=-score (Relevance)
csk=start_date (Start Date)
csk=-ongoing (Ongoing)
Also ensure refreshing the page with the specified query parameter keeps the sort order as it should be.
Then login. Check your user preferences and make note of your Collection Sort preference. Go the the EDSC homepage and make sure the collections are sorted based on your preference.
Then select a new preference and repeat. Make sure the selected preference is how the collections get sorted initially on the home page and that your selected preference is highlighted as the active sorting option. Make sure your preference does not show up as a query parameter.
Selecting a new preference from the drop down, however will add the proper query parameter to the URL and the collections get sorted with the new parameter.
Refreshing the page with a proper csk parameter set will also yield the expected results. (proper collection sorting and correctly highlighted text)
Attachments
Checklist