cFE Integration candidate: Caelum-rc4+dev60 #2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the current CRC-16 algorithm to a separate source file and better structure the code to support future CRC algorithm alternatives. Improve documentation to better indicate what the current algorithm is and what to expect going forward. Also corrects for issues in the CRC functional test: - Use the standard check input and compare against the standard check value for CRC-16/ARC. - Change cases from MIR to a normal test case - given a specific algorithm with specific input, the return value should be the same.
Fix #2436, Adds an empty string or null pointer check for pipe creation
Fix #2449, crc calculation refactor
| return 0; | ||
| } | ||
|
|
||
| uint32 CFE_ES_ComputeCRC_Algo_16_ARC(const void *DataPtr, size_t DataLength, uint32 InputCRC) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion
| return Crc; | ||
| } | ||
|
|
||
| CFE_ES_ComputeCRC_Params_t *CFE_ES_ComputeCRC_GetParams(CFE_ES_CrcType_Enum_t CrcType) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion
| #include "common_types.h" | ||
| #include "cfe_es.h" | ||
|
|
||
| typedef uint32 (*const CFE_ES_ComputeCRC_Algo_t)(const void *DataPtr, size_t DataLength, uint32 InputCRC); |
Check notice
Code scanning / CodeQL-coding-standard
Hidden pointer indirection
Fix #2436, Adds an empty string or null pointer check for pipe creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Testing performed
cFS Bundle Checks
cFE Checks
Expected behavior changes
See PRs
System(s) tested on
Ubuntu 20.04
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
@chillfig
@jphickey