Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Use a generic
void*
as the interface type for the pool buffer pointers. This reduces the need for local type casting in the apps and makes it generally easier to use.Fixes #1021
Testing performed
Build and sanity test CFE
Run all unit tests
Expected behavior changes
No impact to behavior.
System(s) tested on
Ubuntu 20.04
Additional context
Note that getting a buffer in one step still requires a type cast, as the interface here is really
void**
. However when putting or querying a buffer no cast is needed. One can also avoid the need to cast if they get a buffer in two steps (i.e. get asvoid*
first, then convert to real type with a simple assignment.Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.