Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "UtTest_Setup" as name of entry point for unit tests #435

Closed
jphickey opened this issue Dec 18, 2019 · 0 comments · Fixed by #479 or #436
Closed

Use "UtTest_Setup" as name of entry point for unit tests #435

jphickey opened this issue Dec 18, 2019 · 0 comments · Fixed by #479 or #436
Milestone

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
In nasa/osal#294, The UT assert library is being modified to use a different entry point function name for unit test code, not OS_Application_Startup() as is used for a normal application.

Describe the solution you'd like
The CFE unit tests need to use UtTest_Setup instead.

Describe alternatives you've considered
Any name could work for test setup, but the issue is that it has to be different than that of a normal application. This is so the normal entry point can be provided by UT assert here, allowing better layering.

Additional context
Changing the name of the Test entry point makes more sense because these only use the OSAL BSP but run with the stub library for OSAL itself. It is therefore not really accurate to name the entry point as OS_Application_Startup because this is not an OSAL application at all, it is a unit test.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

jphickey added a commit to jphickey/cFE that referenced this issue Dec 18, 2019
Use "UtTest_Setup" instead of "OS_Application_Startup"

This needs to be merged in coordination with a related change
in OSAL/UT Assert.  This also updates the UT application final
link to use "ut_assert" rather than "ut_bsp", as the separate
bsp for unit test is also getting phased out.
skliper added a commit that referenced this issue Jan 10, 2020
skliper added a commit that referenced this issue Jan 10, 2020
Fix #259 #425 #427 #435 #437 #438 #443 #445
Reviewed and approved at 2020-01-08 CCB
skliper added a commit that referenced this issue Jan 14, 2020
Fix #435: Update UT entry point
Resolve merge conflicts in fsw/cfe-core/unit-test/CMakeLists.txt
@skliper skliper added this to the 6.8.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants