Match DOIs with multiple slashes #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakota002
approved these changes
Feb 22, 2024
|
Looks good, just needs to run prettier |
Darn. I'll set up pre-commit hooks, etc. |
|
Oh, weird. It's complaining about README.md, not one of the files that I touched. I'll fix that on main. |
We assumed that DOI suffixes could only have a single slash, but they can have more than one slash. For example, in the DOI `10.1093/mnras/stz2357`, the prefix is `10.1093` and the suffix is `mnras/stz2357`.
95c7d83 to
52f3b9e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 55 55
Branches 3 3
=========================================
Hits 55 55 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We assumed that DOI suffixes could only have a single slash, but they can have more than one slash. For example, in the DOI
10.1093/mnras/stz2357, the prefix is10.1093and the suffix ismnras/stz2357.