Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circulars: enable basic lucene search #2485

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

tylerbarna
Copy link
Member

Description

this commit adds the most basic form of lucene search, which can be enabled by adding the CIRCULARS_LUCENE feature flag. Additional tuning of field weighting and some type of workaround for the autor search will be required to make it more functional, as well as documentation instructing users on making use of lucene search.

Related Issue(s)

tracked by #2288

Testing

  1. Add the feature flag CIRCULARS_LUCENE to one's .env file
  2. Navigate to Circulars Archive
  3. Search for a term using lucene syntax (example: subject:GRB*)
  4. Search should execute a wildcard search for subjects that contain the term "GRB"

this commit adds the most basic form of lucene search, which can be enabled by adding the CIRCULARS_LUCENE feature flag. Additional tuning of field weighting and some type of workaround for the autor search will be required to make it more functional, as well as documentation instructing users on making use of lucene search.
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 5.27%. Comparing base (ba2ba0f) to head (084a1fb).
Report is 69 commits behind head on main.

Files Patch % Lines
app/routes/circulars/circulars.server.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #2485      +/-   ##
========================================
- Coverage   5.29%   5.27%   -0.02%     
========================================
  Files        157     157              
  Lines       3894    3906      +12     
  Branches     415     419       +4     
========================================
  Hits         206     206              
- Misses      3687    3699      +12     
  Partials       1       1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lpsinger lpsinger merged commit 46ec6cc into nasa-gcn:main Jul 25, 2024
12 checks passed
@tylerbarna tylerbarna deleted the circulars-basic-lucene-search branch July 25, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants