Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close Circular and Schema Version Dropdowns When Clicking Away #2362

Merged

Conversation

tylerbarna
Copy link
Member

Description

This adds the functionality from #1989 to the other two dropdown menus located in the repo at the moment: the version dropdown menus for the Schema browser and any circulars with multiple versions.

The method for determining if the dropdown content is shown or hidden for these has also been updated to match the other two dropdowns.

Related Issue(s)

Resolves #2345

Testing

Schema Browser Dropdown:

  1. Navigate to Docs page
  2. Select 'Schema Browser' in menu
  3. Click on Version dropdown in upper right-hand corner to expand the dropdown content
  4. Clicking on the button again should collapse the dropdown content, and clicking elsewhere on the page while the dropdown is expanded should also collapse it

Circulars Dropdown:

  1. Navigate to a Circular with multiple versions (example: 34776)
  2. Click on Version dropdown in upper right-hand corner to expand the dropdown content
  3. Clicking on the button again should collapse the dropdown content, and clicking elsewhere on the page while the dropdown is expanded should also collapse it

this fixes the schema browser dropdown to dissapear when clicking away a la nasa-gcn#1989
as before, fixes the dropdown in circulars that have been revised to hide the dropdown when clicking away
tylerbarna

This comment was marked as outdated.

Copy link
Member

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is failing due to unused imports. Please fix.

odd, prettier was run on the file
changed to match other implementations of dropdowns
@lpsinger
Copy link
Member

Thank you!

@lpsinger lpsinger merged commit f23abf7 into nasa-gcn:main Jun 10, 2024
10 checks passed
@tylerbarna tylerbarna deleted the circulars-close-dropdowns-on-click-away branch June 10, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically close version dropdowns for Circulars and Schema Browser when clicking outside
2 participants