Submitting Circular correction causes loss of seconds precision on submission time

[lpsinger]

Current behavior

When you request a correction, it appears that the submission time is truncated to the nearest minute.

Expected behavior

Seconds precision should be preserved, and time picker should show seconds precision.

Steps to reproduce

Environment

Unknown

[Courey]

@lpsinger I let you know that the current time picker did not support seconds granularity. You wanted me to use the HTML input with type time instead. I have run into some issues with this approach.

In the image below you will see in the terminal that the values in default time and the time hook are both correct. They account for seconds and are in the requested 24 hour format. Unfortunately the browser detects your system settings and if you are using 12 hour time on your computer, the browser will convert times from 24 hour to 12 hour and add the AM/PM selector.

It also does not seem to handle seconds granularity well. While I can get the seconds to display properly, if you hover over the input, you can see an error message that indicates seconds are not valid and prevents submission.

I believe we will have to use a package or custom input to handle both seconds and 24 hour time. A custom approach is inadvisable.

Would using react time picker be an adequate solution? Here is the github repo. Here is the NPM page. I have not tried it yet (or any other packages for that matter). I figured I'd check in and see if you have any strong preferences first.

[lpsinger]

Let's start with just the native <input type="time"> because that will at least fix the bug. Let's get that merged first. Then maybe we can try out the third-party component.

[Courey]

This was the native <input type="time">

[lpsinger]

Yes, I know. The current implementation already has the problem that it uses the locale rather than 24-hour time. I don't understand the validation error, but I'm sure we can fix that. Would you please make a draft PR? I can help you with it.

[Courey]

Ah, are saying forget about the 24 hour part and just do the seconds and we can handle the 24 hour format later?

[lpsinger]

Ah, are saying forget about the 24 hour part and just do the seconds and we can handle the 24 hour format later?

Yes.