feat: arrow join methods #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
commented
Jul 19, 2024
| result = df.join(df, how="cross") # type: ignore[arg-type] | ||
|
|
||
| expected = {"a": [1, 1, 1, 3, 3, 3, 2, 2, 2], "a_right": [1, 3, 2, 1, 3, 2, 1, 3, 2]} | ||
| result = df.join(df, how="cross").sort("a", "a_right") # type: ignore[arg-type] |
There was a problem hiding this comment.
Without sorting, the result is flaky as order is not guaranteed
|
amazing! vega/altair#3487 should fix the CI failure |
FYI, that PR just got merged |
MarcoGorelli
approved these changes
Jul 20, 2024
Comment on lines
+235
to
+236
| self.with_columns(**{key_token: plx.lit(0, None)})._native_dataframe.join( | ||
| other.with_columns(**{key_token: plx.lit(0, None)})._native_dataframe, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.
Implements various join types for arrow and
fill_null(as it is used in one test)I am mostly trusting our tests at this point :)