-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: explain optional boolean args in from_native #1421
docs: explain optional boolean args in from_native #1421
Conversation
Is there a reason to have |
For some of these, yes - good call. That would still be backwards-compatible. For others (e.g. The other one which we can't change is Agree on simplifying where possible though, thanks π |
# Hopefully temporary until https://github.com/mkdocstrings/mkdocstrings/issues/716 | ||
git+https://github.com/MarcoGorelli/griffe.git@no-overloads |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
temporary (hopefully π€ ) workaround for mkdocstrings/mkdocstrings#716
thanks for your review, and thanks @emilykl for helping us improve the docs, really appreciate this and the other suggestions you made! |
closes #1420
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below