feat: support constraints in DataFrame.filter
#1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raisadz thank you for this! Not sure if this suggestion could fit into the I'm using this with an unpacked
No worries at all if not, thanks again for working on this PR 🎉 |
MarcoGorelli
approved these changes
Nov 23, 2024
There was a problem hiding this comment.
thanks @raisadz , awesome work here!
and thanks @dangotbanned for the suggestion + review
I like TypedDict but I'm not sure about adding it to the filter docstring or it risks getting too long - perhaps we need a "tips and tricks" page in the docs?
dangotbanned
added a commit
to vega/altair
that referenced
this pull request
Nov 24, 2024
Feature has been adopted upstream in narwhals-dev/narwhals#1417
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
constraintsinDataFrame.filter#1383Checklist
If you have comments or can explain your changes, please do so below