Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use from_native / to_native in series.py #1406

Merged
merged 13 commits into from
Nov 19, 2024

Conversation

MarcoGorelli
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

  • Related issue #<issue number>
  • Closes #<issue number>

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 19, 2024
narwhals/series.py Outdated Show resolved Hide resolved
narwhals/series.py Outdated Show resolved Hide resolved
@MarcoGorelli MarcoGorelli marked this pull request as ready for review November 19, 2024 15:24
@FBruzzesi
Copy link
Member

Commenting just for visibility and sharing my opinion. I have some mixed feelings about my_library_agnostic_function naming πŸ˜‡ Maybe it could be a good community topic for Friday call?

@MarcoGorelli
Copy link
Member Author

πŸ˜„ yup, definitely!

i think it's still clearer than func though - ok to merge as-is before merge conflicts come in, and then we do a find-and-replace when we decide on a better name?

@MarcoGorelli MarcoGorelli merged commit 0f3cff6 into narwhals-dev:main Nov 19, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants