-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding ewm_mean #1298
Merged
Merged
feat: Adding ewm_mean #1298
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
fc64937
wip
DeaMariaLeon 3d1e466
wip
DeaMariaLeon ac0c3f7
latex works
DeaMariaLeon 14dd1c5
doc test series
DeaMariaLeon a4b5bd7
expr docstring
DeaMariaLeon 686e33c
added to pandaslikeexpr
DeaMariaLeon 9113a9d
added wip test
DeaMariaLeon 212b78a
wip
DeaMariaLeon 1bf1571
Merge remote-tracking branch 'upstream/main' into ewm
DeaMariaLeon cd986f0
after merge
DeaMariaLeon e5b9486
added dask not implemented error test
DeaMariaLeon 1dfab2c
added test with nulls
DeaMariaLeon 6f738cd
example with nulls
DeaMariaLeon 0cdb0c3
Merge remote-tracking branch 'upstream/main' into ewm
DeaMariaLeon 73cc573
fixed mkdocs issue
DeaMariaLeon 5cd4833
Match polars' None in input
DeaMariaLeon 130322e
Merge remote-tracking branch 'upstream/main' into ewm
DeaMariaLeon 19da3a3
polars version
DeaMariaLeon 6cc0a96
polars version again
DeaMariaLeon afb3ed3
again
DeaMariaLeon ee2e916
wip
DeaMariaLeon 7f872cf
add modin to xfail
DeaMariaLeon 6fdaa29
Merge remote-tracking branch 'upstream/main' into ewm
DeaMariaLeon 3cbfe53
ewm_mean not implemented yet for old Polars
DeaMariaLeon 6368b04
after conflict
DeaMariaLeon a6c4525
remove unused test
DeaMariaLeon a67aef0
parametrize expected
DeaMariaLeon f8d438a
after merge conflict
DeaMariaLeon 0c34a55
Merge remote-tracking branch 'upstream/main' into ewm
DeaMariaLeon eddceb4
test parameters
DeaMariaLeon fdeb4dc
Merge remote-tracking branch 'upstream/main' into ewm
DeaMariaLeon 8787b65
Merge remote-tracking branch 'upstream/main' into ewm
DeaMariaLeon 3f2a26d
added warning
DeaMariaLeon e8eb645
remove nan example, https://github.com/narwhals-dev/narwhals/issues/1401
MarcoGorelli bbe2cae
use None in test
MarcoGorelli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,6 +18,7 @@ | |
- cum_sum | ||
- diff | ||
- drop_nulls | ||
- ewm_mean | ||
- fill_null | ||
- filter | ||
- gather_every | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,6 +23,7 @@ | |
- diff | ||
- drop_nulls | ||
- dtype | ||
- ewm_mean | ||
- fill_null | ||
- filter | ||
- gather_every | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
.highlight .gp, .highlight .go { /* Generic.Prompt, Generic.Output */ | ||
user-select: none; | ||
-webkit-user-select: none; /* Safari */ | ||
-moz-user-select: none; /* Firefox */ | ||
-ms-user-select: none; /* Internet Explorer/Edge */ | ||
color: red; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
document$.subscribe(({ body }) => { | ||
renderMathInElement(body, { | ||
delimiters: [ | ||
{ left: "$$", right: "$$", display: true }, | ||
{ left: "$", right: "$", display: false }, | ||
{ left: "\\(", right: "\\)", display: false }, | ||
{ left: "\\[", right: "\\]", display: true } | ||
], | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a lot of parameters here, do we have a test which hits each of them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add tests for the parameters then...
(I can't hit all the parameters in only one test, at least not the first 4 I think)..Is that what you meant?