Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop execution on some exceptions #83

Merged

Conversation

EpicPlayerA10
Copy link
Collaborator

@EpicPlayerA10 EpicPlayerA10 commented Aug 29, 2024

Many people are confused when exception happens and the program continues to run. This creates undefined behaviour.

Also made so parent directory for output jar is automatically created.

@narumii
Copy link
Owner

narumii commented Aug 29, 2024

this is intended feature

@EpicPlayerA10
Copy link
Collaborator Author

this is intended feature

Are you sure? For example if loading jar throws exception, the program shouldn't continue to run.

@narumii
Copy link
Owner

narumii commented Aug 29, 2024

this is intended feature

Are you sure? For example if loading jar throws exception, the program shouldn't continue to run.

if some library can't be loaded it doesn't mean we can't try to deobfuscate the jar, same with zip entries/classes(or fake classes)
sometimes some of the obfuscated classes may not be saved due to invalid bytecode but there are other classes and that one may not be important

ofc it would be hard to deobfuscate jar that can't be loaded but in most cases it is intended feature

@EpicPlayerA10
Copy link
Collaborator Author

Alright, i added back suppressing errors where it makes sense to suppress them.

@narumii narumii merged commit a14e171 into narumii:master Aug 29, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants