Add text user interface for deleting s3 bucket #36
Conversation
| } | ||
|
|
||
| // s3hubDeleteContentsStatus is the status of the delete contents operation. | ||
| func newS3hubDeleteContentsModel() (*s3hubDeleteContentsModel, error) { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶newS3hubDeleteContentsModel is unused (deadcode)
| startIndex = len(m.bucketSets) - windowHeight | ||
| endIndex = len(m.bucketSets) | ||
| } | ||
| } else { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
elseif: can replace 'else {if cond {}}' with 'else if cond {}' (gocritic)
| // region is the AWS region that the user wants to create the S3 bucket. | ||
| region model.Region | ||
| // choice is the currently selected menu item. | ||
| choice *ui.Choice |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶choice is unused (structcheck)
| // quitting is true when the user has quit the application. | ||
| quitting bool | ||
| // awsConfig is the AWS configuration. | ||
| awsConfig *model.AWSConfig |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
field awsConfig is unused (unused)
| // awsConfig is the AWS configuration. | ||
| awsConfig *model.AWSConfig | ||
| // awsProfile is the AWS profile. | ||
| awsProfile model.AWSProfile |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
field awsProfile is unused (unused)
| // awsProfile is the AWS profile. | ||
| awsProfile model.AWSProfile | ||
| // region is the AWS region that the user wants to create the S3 bucket. | ||
| region model.Region |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
field region is unused (unused)
| // choice is the currently selected menu item. | ||
| choice *ui.Choice | ||
| // app is the S3 application service. | ||
| app *di.S3App |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
field app is unused (unused)
| // app is the S3 application service. | ||
| app *di.S3App | ||
| // ctx is the context. | ||
| ctx context.Context |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
field ctx is unused (unused)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
HOTTEST report
Reported by hottest |
Code Metrics Report
Details | | main (a01b622) | #36 (b3901c7) | +/- |
|---------------------|----------------|---------------|-------|
- | Coverage | 32.7% | 28.6% | -4.1% |
| Files | 38 | 39 | +1 |
| Lines | 1103 | 1262 | +159 |
| Covered | 361 | 361 | 0 |
+ | Test Execution Time | 33s | 11s | -22s |Code coverage of files in pull request scope (0.4% → 0.3%)
Reported by octocov |
No description provided.