Merge branch 'dev' of https://github.com/nanograv/holodeck into dev

* 'dev' of https://github.com/nanograv/holodeck:
  Warn users when there may be an inconsistent library parameter passed

holodeck/librarian/lib_tools.py

@@ -169,6 +169,7 @@ def model_for_params(self, params, sam_shape=None):
         hard : :class:`holodeck.hardening._Hardening` instance
 
         """
+        log = self._log
 
         if sam_shape is None:
             sam_shape = self.sam_shape
@@ -202,6 +203,16 @@ def model_for_params(self, params, sam_shape=None):
                 self._log.exception(err)
                 raise ValueError(err)
 
+            # Nowhere is it required that all parameters have values stored in the default settings (`DEFAULTS`).
+            # For that reason, we don't raise an error if a passed parameter is not already in the defaults.
+            # But a good parameter space class should probably always have a default value set.
+            # An error may be raised in the future.
+            if name not in settings:
+                log.warning(
+                    f"`params` has key '{name}' which is not already in the default settings!  "
+                    f"Ensure '{name}' is consistent with this parameter space ({self})!"
+                )
+
             settings[name] = value
 
         # ---- Construct SAM and hardening model
@@ -329,7 +340,7 @@ def from_save(cls, fname, log=None):
             pspace_class = cls
 
         # construct instance with dummy/temporary values (which will be overwritten)
-        if data['param_samples'][()] is None:
+        if np.all(data['param_samples'] == None):   # noqa : use ``== None`` to match arrays
             nsamples = None
             nparameters = None
         else: