-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing platform tag from CloudSmith package #309
Conversation
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (3)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Motivation and Context
Until now the firmware archive manager uses the platform as it is derived by logic in the nanoff program. For some targets (in my case XIAO_ESP32C3) the logic cannot determine the correct platform. As a consequence,
nanoff --listtargets --fromarchive --platform X
will not return the same targets asnanoff --listtargets --fromarchive --platform X
.The changes in this PR parse the tags of the CloudSmith package details and keep the tag that matches one of the SupportedPlatform values.
After the change, the platform is copied correctly to the firmware archive for all targets except SL_STK3701A_REVB
and NXP_MIMXRT1060_EVK, as the tags for those do not include any of the SupportedPlatform values.
How Has This Been Tested?
Types of changes
Checklist: