Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing DFU detection for PyBStick and DFU Driver installation #208

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

Ellerbach
Copy link
Member

Description

Fixing DFU detection for PyBStick and DFU Driver installation

Motivation and Context

  • Fixing DFU detection for PyBStick and DFU Driver installation
  • Both related to missplacing ESP32 elements

How Has This Been Tested?

in real command line

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

@nfbot nfbot added the Type: Bug Something isn't working label Apr 17, 2023
@Ellerbach Ellerbach requested a review from networkfusion April 17, 2023 14:59
Copy link
Member

@networkfusion networkfusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@networkfusion networkfusion merged commit 4ca230f into main Apr 17, 2023
@networkfusion networkfusion deleted the fix-dfu-community-target branch April 17, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants