Skip to content

Commit

Permalink
Fix S3 broken --masserase option (#274)
Browse files Browse the repository at this point in the history
  • Loading branch information
CoryCharlton authored Jun 4, 2024
1 parent 18c31ba commit eb003fb
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions nanoFirmwareFlasher.Library/EspTool.cs
Original file line number Diff line number Diff line change
Expand Up @@ -247,12 +247,17 @@ public Esp32DeviceInfo GetDeviceDetails(
// these series doesn't have PSRAM
psramIsAvailable = PSRamAvailability.No;
}
else if (_chipType == "esp32s3")
{
// For now assuming all S3 have PSRAM.
// TODO: following https://github.com/espressif/esptool/issues/970
// The download mode register is not cleared so a reset/run command does not work on the S3. We should retest this after depending on what will be the fix for that issue.
psramIsAvailable = PSRamAvailability.Undetermined;
}
else
{
//try to find out if PSRAM is present
psramIsAvailable = FindPSRamAvailable(
out psRamSize,
forcePsRamCheck);
psramIsAvailable = FindPSRamAvailable(out psRamSize, forcePsRamCheck);
}

if (Verbosity >= VerbosityLevel.Normal)
Expand Down

0 comments on commit eb003fb

Please sign in to comment.