Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated readme #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

molinto
Copy link
Contributor

@molinto molinto commented Oct 10, 2017

No description provided.

@sdomino
Copy link
Contributor

sdomino commented Oct 10, 2017

@molinto, I think this is a great change, but I have one comment (same as I made in the sails.js quickstart). I wonder if this becomes a nanobox destroy to just clean the whole thing up (DNS alias included).

@sdomino
Copy link
Contributor

sdomino commented Oct 10, 2017

@molinto, I spoke with @sanderson and ultimately we agreed that since the context of what we're trying to do here is "clean up", a nanobox destroy makes the most sense. Simply removing the DNS alias leaves around a lot of extra stuff related to the project (containers, networking, etc).

I think for these if we could change it to nanobox destroy that would be preferable. We can update the other ones that we've already merged. Unless you're up for it (which would be awesome 😉 ).

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants