Free Gas Tracker Endpoints #74
Conversation
There was a problem hiding this comment.
Thanks for your contribution, again!
The unit tests currently just check for existence of a value and no error for the Gas Tracker methods since each call generates dynamic data. Is there a way to test with static data?
Personally I think it's good enough. The value is dynamic, so any value >= 0 is good.
gas_tracker.go
Outdated
| package etherscan | ||
|
|
||
| // GasEstiamte gets estiamted confirmation time (in seconds) at the given gas price | ||
| func (c *Client) GasEstimate(gasPrice int) (confirmationTimeInSec string, err error) { |
There was a problem hiding this comment.
Maybe we should make confirmationTimeInSec a int? An user of this method may find it handy.
There was a problem hiding this comment.
An int is good, a time.Duration is better IMO.
response.go
Outdated
| //Gas Prices are returned in Gwei | ||
| type GasPrices struct { | ||
| LastBlock string | ||
| SafeGasPrice string |
There was a problem hiding this comment.
Since gas price is in Gwei, maybe we should use a float64?
I am curious, what data type are you using when you consume GasPrices struct? We may use the type dirctly so that our user don't have to do the convertion by themselves.
There was a problem hiding this comment.
I think having LastBlock be an int and converting the prices to either float64 or decimal.Decimal is better. I personally would consume the Gas prices as decimal.Decimal, however, I understand not going that route since the idea behind this API is to leverage the go standard library.
I left it as a string since that's what the API returns, however, I'll looking into converting into a numeric type.
7137647 to
384329f
Compare
Implementation for Free Gas Tracker Endpoints (partial implementation of Issue #70).
I can use suggestions for:
1.) Values returned: Etherscan returns everything as a string so the methods currently return everything as a string as well. I'm open to writing custom JSON Unmarshal methods to convert the comma separated strings into slices and convert numeric string values into float64/decimal.Decimal.
2.) The unit tests currently just check for existence of a value and no error for the Gas Tracker methods since each call generates dynamic data. Is there a way to test with static data?