Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Image illustrations display and sizing #374

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Conversation

evadecker
Copy link
Member

What changed?

Optimize header images for quests. Import images with Vite so the final asset is compiled and displays properly in prod. Fixes #356

Why?

Images were broken and too large.

How was this change made?

Resized and optimized images, relocated them within src/ instead of public/.

How was this tested?

Tested preview deploy to verify images display.

Copy link

changeset-bot bot commented Feb 5, 2025

⚠️ No Changeset found

Latest commit: 8da15b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added bug Something isn't working frontend CSS, HTML, and JS changes labels Feb 5, 2025
Copy link

cloudflare-workers-and-pages bot commented Feb 5, 2025

Deploying namesake with  Cloudflare Pages  Cloudflare Pages

Latest commit: 805e154
Status: ✅  Deploy successful!
Preview URL: https://69b2f086.namesake-639.pages.dev
Branch Preview URL: https://fix-illustrations.namesake-639.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 52.83%
🟰 ±0%
3753 / 7103
🔵 Statements 52.83%
🟰 ±0%
3753 / 7103
🔵 Functions 57.38%
🟰 ±0%
171 / 298
🔵 Branches 80.38%
🟰 ±0%
332 / 413
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/components/quests/QuestPageHeader/QuestPageHeader.tsx 1.7%
🟰 ±0%
100%
🟰 ±0%
0%
🟰 ±0%
1.7%
🟰 ±0%
36-67, 70-185
Generated in workflow #303 for commit 805e154 by the Vitest Coverage Report Action

@evadecker evadecker merged commit 4fafdc2 into main Feb 5, 2025
11 checks passed
@evadecker evadecker deleted the fix-illustrations branch February 5, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend CSS, HTML, and JS changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix and optimize images in prod
1 participant