Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Align AppSidebar to edge of browser #363

Merged
merged 1 commit into from
Jan 31, 2025
Merged

fix: Align AppSidebar to edge of browser #363

merged 1 commit into from
Jan 31, 2025

Conversation

evadecker
Copy link
Member

What changed?

Shift the alignment of AppSidebar to the edge of the browser screen, instead of center aligning it with content. Change the background color to differentiate from main app.

Additionally, fix "No quest found" empty state to display the default 404 / empty page, since the $questSlug is at the main level.

Before After
CleanShot 2025-01-31 at 17 59 10@2x CleanShot 2025-01-31 at 17 58 57@2x

Why?

Left-aligning the sidebar means we can use a different color to separate it from the main contents, and will make it easier to adapt to mobile. It also gives more breathing room to the content itself.

How was this change made?

Added convex as a context object in TanStack Router so that it may be used within loader without a hook.

How was this tested?

N/A

Copy link

changeset-bot bot commented Jan 31, 2025

🦋 Changeset detected

Latest commit: c9f86e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
namesake Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the frontend CSS, HTML, and JS changes label Jan 31, 2025
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 52.83%
⬇️ -0.07%
3753 / 7103
🔵 Statements 52.83%
⬇️ -0.07%
3753 / 7103
🔵 Functions 57.38%
🟰 ±0%
171 / 298
🔵 Branches 80.38%
🟰 ±0%
332 / 413
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/main.tsx 0%
🟰 ±0%
0%
🟰 ±0%
0%
🟰 ±0%
0%
🟰 ±0%
1-130
src/components/app/AppContent/AppContent.tsx 0%
🟰 ±0%
0%
🟰 ±0%
0%
🟰 ±0%
0%
🟰 ±0%
1-11
src/components/app/AppSidebar/AppSidebar.tsx 0%
🟰 ±0%
0%
🟰 ±0%
0%
🟰 ±0%
0%
🟰 ±0%
1-97
src/routes/__root.tsx 0%
🟰 ±0%
0%
🟰 ±0%
0%
🟰 ±0%
0%
🟰 ±0%
1-103
src/routes/_authenticated/_home.tsx 0%
🟰 ±0%
0%
🟰 ±0%
0%
🟰 ±0%
0%
🟰 ±0%
1-176
src/routes/_authenticated/_home/$questSlug.index.tsx 0%
🟰 ±0%
0%
🟰 ±0%
0%
🟰 ±0%
0%
🟰 ±0%
1-78
src/routes/_authenticated/admin/route.tsx 0%
🟰 ±0%
0%
🟰 ±0%
0%
🟰 ±0%
0%
🟰 ±0%
1-44
src/routes/_authenticated/settings/route.tsx 0%
🟰 ±0%
0%
🟰 ±0%
0%
🟰 ±0%
0%
🟰 ±0%
1-96
Generated in workflow #295 for commit c9f86e8 by the Vitest Coverage Report Action

@evadecker evadecker merged commit ca58bb2 into main Jan 31, 2025
11 checks passed
@evadecker evadecker deleted the primary-layout branch January 31, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend CSS, HTML, and JS changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant