fix: Align AppSidebar
to edge of browser
#363
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Shift the alignment of
AppSidebar
to the edge of the browser screen, instead of center aligning it with content. Change the background color to differentiate from main app.Additionally, fix "No quest found" empty state to display the default 404 / empty page, since the
$questSlug
is at the main level.Why?
Left-aligning the sidebar means we can use a different color to separate it from the main contents, and will make it easier to adapt to mobile. It also gives more breathing room to the content itself.
How was this change made?
Added
convex
as acontext
object in TanStack Router so that it may be used withinloader
without a hook.How was this tested?
N/A