Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update design for links and docs sections #346

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

evadecker
Copy link
Member

@evadecker evadecker commented Jan 28, 2025

What changed?

  • Update design for links (now "references") and documents sections within a quest
  • Show empty states when no content exists during editing
  • Create a new QuestSection component for handling displaying headings and actions for a section
  • Relocate references and documents to the bottom of the page

CleanShot 2025-01-27 at 19 54 46@2x

CleanShot 2025-01-27 at 19 54 26@2x

Why?

Design tweaks.

How was this tested?

No testing.

Anything else?

Tweak button border hover styles.

Copy link

changeset-bot bot commented Jan 28, 2025

⚠️ No Changeset found

Latest commit: b76ef2d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added dependencies Pull requests that update a dependency file frontend CSS, HTML, and JS changes labels Jan 28, 2025
Copy link

cloudflare-workers-and-pages bot commented Jan 28, 2025

Deploying namesake with  Cloudflare Pages  Cloudflare Pages

Latest commit: c61333f
Status: ✅  Deploy successful!
Preview URL: https://9a741baf.namesake-639.pages.dev
Branch Preview URL: https://link-docs-organization.namesake-639.pages.dev

View logs

@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Jan 28, 2025
@evadecker evadecker merged commit 6a2bc7b into main Jan 28, 2025
10 checks passed
@evadecker evadecker deleted the link-docs-organization branch January 28, 2025 00:55
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 54.95%
⬇️ -0.25%
3673 / 6684
🔵 Statements 54.95%
⬇️ -0.25%
3673 / 6684
🔵 Functions 58.38%
⬇️ -0.20%
174 / 298
🔵 Branches 81.59%
🟰 ±0%
328 / 402
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/components/common/Button/Button.tsx 100%
🟰 ±0%
75%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
src/components/common/Modal/Modal.tsx 100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
src/components/common/TextField/TextField.tsx 100%
🟰 ±0%
40%
🟰 ±0%
50%
🟰 ±0%
100%
🟰 ±0%
src/components/quests/QuestDocuments/QuestDocuments.tsx 6.06%
⬆️ +0.66%
100%
🟰 ±0%
0%
🟰 ±0%
6.06%
⬆️ +0.66%
19-63
src/components/quests/QuestSection/QuestSection.tsx 15.38% 100% 0% 15.38% 11-24
src/components/quests/QuestSteps/QuestSteps.tsx 2.79%
⬇️ -0.19%
100%
🟰 ±0%
0%
🟰 ±0%
2.79%
⬇️ -0.19%
27-115, 123-179, 187-228
src/routes/_authenticated/_home/$questSlug.index.tsx 0%
🟰 ±0%
0%
🟰 ±0%
0%
🟰 ±0%
0%
🟰 ±0%
1-71
Generated in workflow #280 for commit c61333f by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend CSS, HTML, and JS changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant