Skip to content

Commit

Permalink
Skip Flakey GivenDotnetTest Tests
Browse files Browse the repository at this point in the history
In this PR a few days ago I disabled some similar tests:
dotnet#46924

It turns out that even more of them are failing about 80%+ of the time
after some recent changes to these tests.

See here: dotnet#47003 (review)
here: dotnet#47004 (review)
here: https://github.com/dotnet/sdk/pull/47004/checks?check_run_id=37586911841
here: dotnet#47014
etc.

I've already made an issue to track this: dotnet#46923
So I'll keep using that one. The maintainer has been notified.
  • Loading branch information
nagilson committed Feb 21, 2025
1 parent 68bf4cb commit 38bfc1e
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public GivenDotnetTestBuildsAndRunsTestsForMultipleTFMs(ITestOutputHelper log) :

[InlineData(TestingConstants.Debug)]
[InlineData(TestingConstants.Release)]
[Theory]
[Theory(Skip= "https://github.com/dotnet/sdk/issues/46923")]
public void RunMultipleProjectWithDifferentTFMs_ShouldReturnExitCodeGenericFailure(string configuration)
{
TestAsset testInstance = _testAssetsManager.CopyTestAsset("ProjectSolutionForMultipleTFMs", Guid.NewGuid().ToString())
Expand Down Expand Up @@ -53,7 +53,7 @@ public void RunMultipleProjectWithDifferentTFMs_ShouldReturnExitCodeGenericFailu

[InlineData(TestingConstants.Debug)]
[InlineData(TestingConstants.Release)]
[Theory]
[Theory(Skip= "https://github.com/dotnet/sdk/issues/46923")]
public void RunProjectWithMultipleTFMs_ShouldReturnExitCodeGenericFailure(string configuration)
{
TestAsset testInstance = _testAssetsManager.CopyTestAsset("TestProjectWithMultipleTFMsSolution", Guid.NewGuid().ToString())
Expand Down Expand Up @@ -100,7 +100,7 @@ public void RunProjectWithMultipleTFMs_ShouldReturnExitCodeGenericFailure(string

[InlineData(TestingConstants.Debug)]
[InlineData(TestingConstants.Release)]
[Theory]
[Theory(Skip= "https://github.com/dotnet/sdk/issues/46923")]
public void RunProjectWithMultipleTFMsWithArchOption_ShouldReturnExitCodeGenericFailure(string configuration)
{
TestAsset testInstance = _testAssetsManager.CopyTestAsset("TestProjectWithMultipleTFMsSolution", Guid.NewGuid().ToString())
Expand Down Expand Up @@ -128,7 +128,7 @@ public void RunProjectWithMultipleTFMsWithArchOption_ShouldReturnExitCodeGeneric

[InlineData(TestingConstants.Debug)]
[InlineData(TestingConstants.Release)]
[Theory]
[Theory(Skip= "https://github.com/dotnet/sdk/issues/46923")]
public void RunProjectWithMSTestMetaPackageAndMultipleTFMs_ShouldReturnExitCodeGenericFailure(string configuration)
{
TestAsset testInstance = _testAssetsManager.CopyTestAsset("MSTestMetaPackageProjectWithMultipleTFMsSolution", Guid.NewGuid().ToString())
Expand Down

0 comments on commit 38bfc1e

Please sign in to comment.