Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aliases for some functions/modules renamed in Python 3. #128

Merged
merged 10 commits into from
May 3, 2020

Conversation

luk3yx
Copy link
Contributor

@luk3yx luk3yx commented Nov 26, 2019

This PR adds the following aliases:

  • collections.abc_abcoll
  • configparserConfigParser (Broken on Windows, this may have to use a meta path importer)
  • copyregcopy_reg
  • http.clienthttplib
  • http.cookiejarcookielib
  • http.cookiesCookie
  • http.serverBaseHTTPServer, CGIHTTPServer, SimpleHTTPServer
  • importlib.reloadreload
  • itertools.filterfalseitertools.ifilterfalse
  • itertools.zip_longestitertools.izip_longest
  • socketserverSocketServer
  • urllib.errorurllib, urllib2
  • urllib.parseurllib, urlparse
  • urllib.requesturllib, urllib2
  • urllib.responseurllib
  • urllib.robotparserrobotparser

@luk3yx
Copy link
Contributor Author

luk3yx commented Apr 22, 2020

Do I need to add more tests?

@stefantalpalaru
Copy link
Collaborator

I think we're good. Let me read the changes one more time and I'll merge it.

@stefantalpalaru stefantalpalaru merged commit 5787e96 into naftaliharris:master May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants